Nighthawk/roll20-character-sheets
1
0
Fork 0
mirror of https://github.com/Nighthawk42/roll20-character-sheets.git synced 2026-09-04 14:12:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #14224 from mrianmerry/pta3/fix/skill-updates

Browse Source 
[PokemonTabletopAdventures_v3] Bug Fix: Corrects attribute names and default values
This commit is contained in:
Kayla Fischer
2025-07-29 11:19:05 -07:00
committed by GitHub
parent a07c21604f 30fa6fa786
commit 02546a86ae
2 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
PokemonTabletopAdventures_v3/PTA3.html
+5 -5
View File
@@ -1048,9 +1048,9 @@
<select class="sheet-no-dropdown" name="attr_engineering_ability_mod" title="Select the attribute you want to use for Engineering/Operation.">
<option value="ATK">Attack</option>
<option value="DEF">Defense</option>
<option value="SPATK">Special Attack</option>
<option selected value="SPATK">Special Attack</option>
<option value="SPDEF">Special Defense</option>
<option selected value="SPD">Speed</option>
<option value="SPD">Speed</option>
</select>
<b class="sheet-info-tooltip" title="Select the attribute you want to use for Engineering/Operation."> ℹ </b>
</span>
@@ -4962,9 +4962,9 @@ const skillOptionsFlags = [
});
// Sleight of Hand
on(`${cMods} change:sleight_ability_mod change:sleightofhandtalent1 change:sleightofhandtalent2 change:sleightofhand sheet:opened`, function (event) {
getAttrs(["sleight_ability_mod"], function (mod) {
const abiMod = `${mod.sleight_ability_mod}MOD`;
on(`${cMods} change:sleightofhand_ability_mod change:sleightofhandtalent1 change:sleightofhandtalent2 change:sleightofhand sheet:opened`, function (event) {
getAttrs(["sleightofhand_ability_mod"], function (mod) {
const abiMod = `${mod.sleightofhand_ability_mod}MOD`;
const source = event.sourceAttribute;
if (source && abilities.includes(source.toUpperCase()) && source.toUpperCase() != abiMod) return;
getSkillAttributes(abiMod, "sleightofhandtalent1", "sleightofhandtalent2", "sleightofhand", "sleightofhand_total");
PokemonTabletopAdventures_v3/README.md
+5
View File
@@ -23,6 +23,11 @@ Things we want to add to the character sheet, presented in no particular order o
## Changelog
### Jul 26, 2025
- Resolved a few niggling issue with skills
- Sleight of Hand had a mismatch in attribute name for the selected ability modifier
- Engineering had the wrong value in the selected attribute drop-down selected by default
### Jul 20, 2025
- Added Collapse/Expand button for all skills, so a single click closes/opens them all
- Added collapsing section for giving held items a description to prevent continuous cross-referencing