From 30fa6fa78647d3223fcce60e084a0c95b049de0b Mon Sep 17 00:00:00 2001
From: Ian Merryweather <mrianmerry@gmail.com>
Date: Sat, 26 Jul 2025 01:14:18 +0100
Subject: [PATCH] fix: Corrects attribute names and default values

- Corrects default selected value for Engineering ability mod dropdown
- Corrects spelling of Sleight of Hand ability mod in scripts to match definitions in html
---
 PokemonTabletopAdventures_v3/PTA3.html | 10 +++++-----
 PokemonTabletopAdventures_v3/README.md |  5 +++++
 2 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/PokemonTabletopAdventures_v3/PTA3.html b/PokemonTabletopAdventures_v3/PTA3.html
index 08a0c7320e..eeea1574e9 100644
--- a/PokemonTabletopAdventures_v3/PTA3.html
+++ b/PokemonTabletopAdventures_v3/PTA3.html
@@ -1048,9 +1048,9 @@
                     <select class="sheet-no-dropdown" name="attr_engineering_ability_mod" title="Select the attribute you want to use for Engineering/Operation.">
                       <option value="ATK">Attack</option>
                       <option value="DEF">Defense</option>
-                      <option value="SPATK">Special Attack</option>
+                      <option selected value="SPATK">Special Attack</option>
                       <option value="SPDEF">Special Defense</option>
-                      <option selected value="SPD">Speed</option>
+                      <option value="SPD">Speed</option>
                     </select>
                     <b class="sheet-info-tooltip" title="Select the attribute you want to use for Engineering/Operation."> ℹ </b>
                   </span>
@@ -4962,9 +4962,9 @@ const skillOptionsFlags = [
   });
 
   // Sleight of Hand
-  on(`${cMods} change:sleight_ability_mod change:sleightofhandtalent1 change:sleightofhandtalent2 change:sleightofhand sheet:opened`, function (event) {
-    getAttrs(["sleight_ability_mod"], function (mod) {
-      const abiMod = `${mod.sleight_ability_mod}MOD`;
+  on(`${cMods} change:sleightofhand_ability_mod change:sleightofhandtalent1 change:sleightofhandtalent2 change:sleightofhand sheet:opened`, function (event) {
+    getAttrs(["sleightofhand_ability_mod"], function (mod) {
+      const abiMod = `${mod.sleightofhand_ability_mod}MOD`;
       const source = event.sourceAttribute;
       if (source && abilities.includes(source.toUpperCase()) && source.toUpperCase() != abiMod) return;
       getSkillAttributes(abiMod, "sleightofhandtalent1", "sleightofhandtalent2", "sleightofhand", "sleightofhand_total");
diff --git a/PokemonTabletopAdventures_v3/README.md b/PokemonTabletopAdventures_v3/README.md
index bb2ecd7301..605c353f28 100644
--- a/PokemonTabletopAdventures_v3/README.md
+++ b/PokemonTabletopAdventures_v3/README.md
@@ -23,6 +23,11 @@ Things we want to add to the character sheet, presented in no particular order o
 
 ## Changelog
 
+### Jul 26, 2025
+- Resolved a few niggling issue with skills
+  - Sleight of Hand had a mismatch in attribute name for the selected ability modifier
+  - Engineering had the wrong value in the selected attribute drop-down selected by default
+
 ### Jul 20, 2025
 - Added Collapse/Expand button for all skills, so a single click closes/opens them all
 - Added collapsing section for giving held items a description to prevent continuous cross-referencing