Nighthawk/roll20-character-sheets
1
0
Fork 0
mirror of https://github.com/Nighthawk42/roll20-character-sheets.git synced 2026-08-30 03:40:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

[goblin quest] Bugfixes: URL typo and name initialization

Browse Source 
Mistook 'q' for 'g' in one URL, also found edge case where 'current_goblin_name' uninitialized with new sheet. Finally, tidied up console logs.
This commit is contained in:
William Barker
2026-05-13 09:16:38 -04:00
parent fea9228d7e
commit 6584a746dd
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
goblin quest/goblinquest.css
+1 -1
View File
@@ -114,7 +114,7 @@ input[type="text"].gqInput {
height: 170px;
margin: 0px 0px 0px 0px;
background-color: transparent;
background-image: url('https://raw.githubusercontent.com/Roll20/roll20-character-sheets/refs/heads/master/qoblin%20quest/GoblinQuest_GoblinX.png');
background-image: url('https://raw.githubusercontent.com/Roll20/roll20-character-sheets/refs/heads/master/goblin%20quest/GoblinQuest_GoblinX.png');
background-repeat: no-repeat;
color: black;
}
goblin quest/goblinquest.html
+5 -5
View File
@@ -306,7 +306,7 @@ on('clicked:initiative', (info) => {
// Set current_goblin_name
on("change:goblin1_hp1 change:goblin1_hp2 change:goblin2_hp1 change:goblin2_hp2 change:goblin3_hp1 change:goblin3_hp2 change:goblin4_hp1 change:goblin4_hp2 change:goblin5_hp1 change:goblin5_hp2", function(eventInfo) {
on("change:goblin1_hp1 change:goblin1_hp2 change:goblin2_hp1 change:goblin2_hp2 change:goblin3_hp1 change:goblin3_hp2 change:goblin4_hp1 change:goblin4_hp2 change:goblin5_hp1 change:goblin5_hp2 change:goblin1_name change:goblin2_name change:goblin3_name change:goblin4_name change:goblin5_name", function(eventInfo) {
let NewName = eventInfo.newValue;
let OldName = eventInfo.previousValue;
let SourceAttribute = eventInfo.sourceAttribute;
@@ -336,7 +336,7 @@ on("change:goblin1_hp1 change:goblin1_hp2 change:goblin2_hp1 change:goblin2_hp2
else if (G4HP1 == 1 || G4HP2 == 1) { GoblinName = G4; }
else if (G5HP1 == 1 || G5HP2 == 1) { GoblinName = G5; }
console.log(" GoblinName: " + GoblinName );
//console.log(" GoblinName: " + GoblinName );
setAttrs({
current_goblin_name: GoblinName
@@ -359,7 +359,7 @@ on("clicked:roll", function(eventInfo) {
let BonusOrPenalty = parseInt(values.bonus_penalty)||0;
let GoblinName = values.current_goblin_name;
let Clutch = values.honorific;
console.log(" Name: " + GoblinName + " Clutch: " + Clutch + " BonusOrPenalty: " + BonusOrPenalty);
//console.log(" Name: " + GoblinName + " Clutch: " + Clutch + " BonusOrPenalty: " + BonusOrPenalty);
@@ -477,7 +477,7 @@ on("clicked:roll", function(eventInfo) {
startRoll(rollBase, rollResult => {
console.log(" rollResult.results.Dice: " + JSON.stringify(rollResult.results.Dice) );
//console.log(" rollResult.results.Dice: " + JSON.stringify(rollResult.results.Dice) );
NumDie = rollResult.results.Dice.result;
//console.log(" !!!! NumDie: " + NumDie );
@@ -489,7 +489,7 @@ on("clicked:roll", function(eventInfo) {
if (Result1 == 'I') { BonusOrPenalty = -1;}
else if (Result1 == 'j') { BonusOrPenalty = 1; }
else { BonusOrPenalty = 0; }
console.log("Roll Cost: NumDie: " + NumDie + " Result1: " + Result1 + " BonusOrPenalty: " + BonusOrPenalty );
//console.log("Roll Cost: NumDie: " + NumDie + " Result1: " + Result1 + " BonusOrPenalty: " + BonusOrPenalty );
setAttrs({ bonus_penalty: 0 });
//console.log(" For Display: Normal " + NumDie);